-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run module publish action only on the main repo #3153
Conversation
scripts/update_package_version.sh
Outdated
@@ -10,6 +10,12 @@ | |||
# Prompt changed packages to manually set the new version | |||
|
|||
if [[ "$GITHUB_RUN_ID" ]]; then | |||
# do not attempt versioning if the NODE_AUTH_TOKEN is missing | |||
if [[ -z "$NODE_AUTH_TOKEN" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: this is under assumption that no one has NODE_AUTH_TOKEN except the people actually wants to publish it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is some sort of placeholder for NODE_AUTH_TOKEN
under forked repos as well. So, this check does NOT work. We need to come up with a better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now using a job level conditional within the workflow yaml file. It seems tricky to check secret variables, so for now just checking the repository name.
Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
1f7dda3
to
34744b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find 👍
Run module publish action only on the main repo Former-commit-id: 47eaa4e
Fix cBioPortal/cbioportal/issues/6970
Checks