Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jitpack build #3189

Merged
merged 1 commit into from May 1, 2020
Merged

Fix jitpack build #3189

merged 1 commit into from May 1, 2020

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal#7460

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
@inodb inodb marked this pull request as ready for review May 1, 2020 23:18
@inodb
Copy link
Member

inodb commented May 1, 2020

Looks like some other screenshot started failing, but is already failing on master so doesn't seem to be related to code: https://69780-66571349-gh.circle-artifacts.com/0/imageCompare.html

@inodb
Copy link
Member

inodb commented May 1, 2020

Thanks so much @onursumer !!

@inodb inodb merged commit d3a2268 into cBioPortal:master May 1, 2020
@inodb inodb added the devops label May 7, 2020
@onursumer onursumer deleted the igv-build-fix branch July 2, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants