For localdb e2e tests use ping from busybox #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was using ping from the backend container to check whether the container is alive. The java 11 image does not have ping. Busybox is a very small image that has tons of common unix utilities, so maybe a decent choice of image to check for liveness. That said I'm not sure if there is a more common approach in e.g. docker itself to check for liveness of a container in a network.
nr23730
approved these changes
May 6, 2020
There was a problem hiding this comment.
Very good that you figured it out!
Didn't think of that. If I hadn't chosen the -slim version of jre this probably wouldn't be an issue...
Makes the e2e pass CI, see: https://app.circleci.com/pipelines/github/cBioPortal/cbioportal/979/workflows/dc9aa3d7-16ad-49cb-9379-c00262e35d1f/jobs/2667/steps
|
@nr23730 good point that it is probably related to slim image 👍. Seems like a good idea regardless to use the I looked at the e2e test failures here but they are not related to this PR so gonna merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was using ping from the backend container to check whether the
container is alive. The java 11 slim image does not have ping. Busybox is a
very small image that has tons of common unix utilities, so maybe a
decent choice of image to check for liveness. That said I'm not sure if
there is a more common approach in e.g. docker itself to check for
liveness of a container in a network.
See backend PR that introduces java 11: cBioPortal/cbioportal#7464