Fix bugs in survival types table and add median survival columns #3452
Conversation
| numPatients: _.sumBy( | ||
| patientSurvivals[prefix], | ||
| s => | ||
| +( |
There was a problem hiding this comment.
what does that plus operator do?
There was a problem hiding this comment.
seems weird adding a boolean?
There was a problem hiding this comment.
plus converts true to 1 and false to 0
There was a problem hiding this comment.
I feel like we should avoid this kind of wizardry/coercion in favor of + (s ? 1 : 0)
adamabeshouse
force-pushed
the
7952-surv-probs
branch
from
1ea8866
to
f0cf29d
Compare
adamabeshouse
changed the title
|
@cBioPortal/product could you please take a look at this one? |
adamabeshouse
force-pushed
the
7952-surv-probs
branch
from
f0cf29d
to
b0ff2ba
Compare
|
The table overlaps with the plot when there are many columns. I am not sure how to address this though...
|
|
@jjgao i think the only thing to do is to make the table horizontally scrollable. that is if we don't want to push the chart rightward. which i don't think we want to do. that raises our favorite issue of whether scrollbar can be on bottom (runs risk that user isn't aware of hidden columns) |
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
7952-surv-probs
branch
from
b0ff2ba
to
10d96c8
Compare
Fixes cBioPortal/cbioportal#7952
Link1
Link2