New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create react-variant-view package #3459
Conversation
b3716a1
to
084234f
Compare
Netlify shows error:
but local is fine |
This is a testing version, it has a lot of things could be cleaned up or updated. We can update it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's make sure that it works in Signal
// TODO customize domain? | ||
export const genomeNexusDomain = 'https://www.genomenexus.org/'; | ||
const genomeNexusInternalClient = new GenomeNexusAPI(genomeNexusDomain); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, most likely we would like to customize this. How do we do the genome nexus client customization for react-mutation-mapper
? Is it possible to do it the same way?
import { VariantAnnotationSummary } from 'genome-nexus-ts-api-client'; | ||
import { getTranscriptConsequenceSummary } from './AnnotationSummaryUtil'; | ||
|
||
export function variantToMutation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to move some of these utility functions into cbioportal-utils
, but I guess it is okay to leave them here at this point.
"react": "^15.0.0 || ^16.0.0", | ||
"react-dom": "^15.0.0 || ^16.0.0" | ||
}, | ||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure that these dependencies are complete. This package may still work inside the monorepo even if some dependencies are not listed here. But when we include the package in another project we may get missing dependency errors. For now we can test it with signal to see if it works fine (after publishing the beta version to npm).
Update ideas:
|
1616fac
to
009fcda
Compare
@onursumer Thank you! I've updated the version and no more complain about it |
Fix cBioPortal/cbioportal#7946
react-variant-view package using for signal.
https://www.npmjs.com/package/react-variant-view
This is a testing version, it has a lot of things could be cleaned up or updated