plots - gracefully handle log scale with rna_seq profiles that have negative numbers #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
force-pushed
the
plots-log-fix
branch
from
7fa8cbd
to
1424f32
Compare
adamabeshouse
force-pushed
the
plots-log-fix
branch
from
1424f32
to
a3f58ab
Compare
alisman
reviewed
Oct 16, 2020
…egative numbers Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
plots-log-fix
branch
from
a3f58ab
to
3a8c288
Compare
alisman
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported by @jjgao:
"Do you why the log scale checkbox is not checked but y-axis is log2? https://bit.ly/3k4iYTR"
This issue was due to the fact that some rna_seq profiles now have small negative values as a result of batch-correction. The solution is that we will not disable the log-scale checkbox for rna_seq profiles even if they have negative values. In addition, log scale rendering for mrna profiles now sets negative values to 0, and then renders log2(value+1)