study view - add timeout before rerendering study view charts #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chronous rendering is jamming things up Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
7977-sv-checkboxes
branch
from
54bc301
to
f46dac6
Compare
alisman
reviewed
Oct 16, 2020
| @@ -376,7 +377,14 @@ export class StudySummaryTab extends React.Component< | |||
| // issue will be solved. | |||
| return ( | |||
| <div key={chartMeta.uniqueKey}> | |||
| <ChartContainer key={chartMeta.uniqueKey} {...(props as any)} /> | |||
| <DelayedRender> | |||
There was a problem hiding this comment.
would be an interesting experiment: if you basically debounce render so that in a space of say x ms, it only actually fires the last render. i would be curious to see if we are in fact getting a lot of these unnecessary render cycles and would benefit from this kind of throttling
alisman
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cBioPortal/cbioportal#7977