Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genome nexus api client #3526

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

onursumer
Copy link
Member

  • Built locally from Genome Nexus master branch
  • API sync will fail until we deploy Genome Nexus master to production

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
@onursumer onursumer added the chore This PR is related to code maintenance label Dec 4, 2020
@onursumer
Copy link
Member Author

Failing tests are not related, merging.

@onursumer onursumer merged commit 5ff1738 into cBioPortal:master Dec 7, 2020
@onursumer onursumer deleted the gn-api-client-update branch December 7, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This PR is related to code maintenance
Projects
None yet
2 participants