Rfc55 Color Chooser #3710
Merged
Rfc55 Color Chooser #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2021 17:37
- All groups will have a color icon which displays the color of the group or is empty if no color was selected. The group color can be changed by clicking on the color icon and select a color from the color picker box. User can also unselect the color (so the group will have no custom color) by clicking again on the selected color. The menu can be closed by clicking outside of the color selection modal.
- When a new group is created, the color icon is either empty or filled with a default color if a category having a predefined color was selected (for example Female : pink). The default color can be changed by the user after creation. However if multiple chart sections with predefined colors were selected (for example Living : green and Female : pink) then the group will have no default color.
- If two groups, that were selected for comparison, have the same color, then a warning sign mark will be displayed in front of the second group. The warning sign has a tooltip with the explanation, which appears at mouse hover. If one of the groups with same colors is unselected for comparison, then the warning sign disappears.
- Group colors are saved in user session. If a user is not logged in, color chooser will work but the group colors will not be saved.
- The group colors are used in the group comparison view. If a group has no custom group color (color icon is empty) the color will default to the current color selection.
Authors: Diana Baiceanu, Pim van Nierop
- added feature flag ff_colorchooser - fixed issue where color is not saved the first time a group is added - cleaned some console.info logs
dianab0
force-pushed
the
rfc55_color_chooser_diana
branch
2 times, most recently
from
2534553
to
bcffc28
Compare
dianab0
force-pushed
the
rfc55_color_chooser_diana
branch
from
bcffc28
to
8523d52
Compare
inodb
added
the
cl-prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group Color Chooser feature can be tested here: https://cbioportal.thehyve.net/ testuser - P@ssword1
All groups will have a color icon which displays the color of the group or is empty if no color was selected. The group color can be changed by clicking on the color icon and select a color from the color picker box. User can also unselect the color (so the group will have no custom color) by clicking again on the selected color. The menu can be closed by clicking outside of the color selection modal.
When a new group is created, the color icon is either empty or filled with a default color if a category having a predefined color was selected (for example Female : pink). The default color can be changed by the user after creation. However if multiple chart sections with predefined colors were selected (for example Living : green and Female : pink) then the group will have no default color.
If two groups, that were selected for comparison, have the same color, then a warning sign mark will be displayed in front of the second group. The warning sign has a tooltip with the explanation, which appears at mouse hover. If one of the groups with same colors is unselected for comparison, then the warning sign dissapears.
Group colors are saved in user session. If a user is not logged in, color chooser will work but the group colors will not be saved.
The group colors are used in the group comparison view. If a group has no custom group color (color icon is empty) the color will default to the current color selection.