Set a limit for whole genome copy number segment viewer #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
reviewed
Apr 20, 2021
| @@ -99,41 +121,57 @@ export default class CNSegments extends React.Component< | |||
| return study ? study.referenceGenome : DEFAULT_GENOME; | |||
| } | |||
|
|
|||
| get selectionInfo() { | |||
| if (!this.isSampleCountWithinThreshold) { | |||
| return 'Too many samples for copy number segmentation view, make a selection on Summary tab first.'; | |||
There was a problem hiding this comment.
Suggested change
| return 'Too many samples for copy number segmentation view, make a selection on Summary tab first.'; | |
| return `Too many samples (>${this.isSampleCountWithinThreshold}) for copy number segmentation view, make a selection on Summary tab first.`; |
maybe good to indicate how many are too many
inodb
approved these changes
Apr 20, 2021
onursumer
force-pushed
the
cn-segments-cap
branch
from
2655037
to
8509f01
Compare
…al/cbioportal#8502) Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
onursumer
force-pushed
the
cn-segments-cap
branch
from
8509f01
to
2e0233a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#8502