Download tab fetch Non-Select profiles data individually #3725
Conversation
| ); | ||
| // find samples which share studyId with profile and add identifier | ||
| const sampleIdentifiers: SampleMolecularIdentifier[] = (samples as Sample[]) | ||
| .filter( |
There was a problem hiding this comment.
there are a couple easy optimizations here. 1. you don't need to filter first. you can just put a condition in the reducer that just returns acc if studyId doesn't appear in selected profile collection.
2. you should use acc.push instead of acc.concat. concat produces a new array each time. so, for every sample, you're producing a new array. push changes array in place, which is find here.
There was a problem hiding this comment.
Good to know the second one, thanks! I will change that.
| this.unzipDownloadDataGroupByKey( | ||
| downloadDataGroupByProfileName | ||
| ) | ||
| onMobxPromise<any>( |
There was a problem hiding this comment.
maybe put a comment above this explaining what "other" means. i think it means non-selected, right?
There was a problem hiding this comment.
I changed those Other to NonSelected
| genes | ||
| ) => { | ||
| // STEP 1: fetch data | ||
| const selectedProfiles: MolecularProfile[] = nonSelectedDownloadableMolecularProfiles.filter( |
There was a problem hiding this comment.
maybe change name selectedProfiles because they are actually NOT selected, right?
There was a problem hiding this comment.
changed to a general term: profiles
| sample.studyId in selectedProfilesGroupByStudyId | ||
| ) | ||
| .reduce((acc: SampleMolecularIdentifier[], sample) => { | ||
| acc = acc.concat( |
| ); | ||
| fileDownload(textMap[profileName], `${profileName}.txt`); | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| @autobind | ||
| private handleTransposedOtherMolecularProfileDownload(profileName: string) { |
There was a problem hiding this comment.
what's difference between this method and the one above?
There was a problem hiding this comment.
merged two methods together and moved into DownloadUtils
dippindots
changed the title
Fix cBioPortal/cbioportal#8528
Fix cBioPortal/cbioportal#8504
Test Link: try download
mRNA Expression, RSEM (Batch normalized from Illumina HiSeq_RNASeqV2)