Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove makeObservable call from ProteinImpactTypeBadgeSelector #3728

Merged

Conversation

onursumer
Copy link
Member

When trying to update to the latest react-mutation-mapper this isse causes Signal to crash in dev mode (and potentially in prod mode).

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
@onursumer onursumer requested review from inodb and leexgh April 30, 2021 17:14
@@ -63,8 +61,8 @@ export class ProteinImpactTypeBadgeSelector<
> extends React.Component<P, {}> {
constructor(props: any) {
super(props);
makeObservable(this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onursumer don't think i fully get what's the issue here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if that fixes it - sounds good to me :)

@inodb inodb added bug chore This PR is related to code maintenance and removed bug labels Apr 30, 2021
@inodb inodb merged commit 5112db9 into cBioPortal:master Apr 30, 2021
@onursumer onursumer deleted the fix-mutation-type-selector-mobx-issue branch April 30, 2021 19:40
@onursumer
Copy link
Member Author

Error message for future reference:

Error: [MobX] No annotations were passed to makeObservable, but no decorator members have been found either
▶ 2 stack frames were collapsed.
new ProteinImpactTypeBadgeSelector
/Users/onur/IdeaProjects/cbioportal-frontend/packages/react-mutation-mapper/dist/index.es.js:3655
  3652 | __extends(ProteinImpactTypeBadgeSelector, _super);
  3653 | function ProteinImpactTypeBadgeSelector(props) {
  3654 |     var _this = _super.call(this, props) || this;
> 3655 |     makeObservable(_this);
  3656 |     return _this;
  3657 | }
  3658 | Object.defineProperty(ProteinImpactTypeBadgeSelector.prototype, "optionDisplayValueMap", {
View compiled
▶ 23 stack frames were collapsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This PR is related to code maintenance
Projects
None yet
2 participants