Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally fetch mutation assessor download data #4106

Merged

Conversation

onursumer
Copy link
Member

Related to cBioPortal/cbioportal#9104

We still need to update the show.genomenexus.annotation_sources property in the backend to make this change effective.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Copy link
Member

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure should we also disable it on mutation table to be consistent?

@leexgh
Copy link
Member

leexgh commented Jan 3, 2022

I've also disabled mutation assessor on genome nexus too, we should find a good way to handle this unstableness

@onursumer
Copy link
Member Author

onursumer commented Jan 3, 2022

Thanks! Not sure should we also disable it on mutation table to be consistent?

@leexgh Seems like we already conditionally show/hide it in the mutation table using the same config prop:

const showMutationAssessor = shouldShowMutationAssessor();

It should be disabled when we set the corresponding prop, right?

@leexgh
Copy link
Member

leexgh commented Jan 3, 2022

@onursumer Oh I forgot we already have this, then it's fine I guess. Do we want to have another pr to disable mutation assessor?

@inodb inodb merged commit 6651d72 into cBioPortal:master Jan 3, 2022
@onursumer onursumer deleted the conditionally-fetch-ma-download-data branch January 10, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants