Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for freqency calculation in study view on study with cal… #4109

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented Jan 3, 2022

Adds test for cBioPortal/cbioportal#9163

A recent backend regression caused a problem with calculation of mutation frequency in study view for studies with called but unprofiled mutations. This e2e test catches this condition on public impact study.

@alisman alisman requested a review from inodb January 3, 2022 20:24
@alisman
Copy link
Collaborator Author

alisman commented Jan 3, 2022

@inodb you think this is sufficient?

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for the quick turnaround!

@inodb inodb added the test label Jan 3, 2022
@alisman alisman force-pushed the calledbut branch 2 times, most recently from b2175e1 to 02579a5 Compare January 3, 2022 21:47
@alisman alisman merged commit 7e02787 into cBioPortal:master Jan 3, 2022
@alisman alisman deleted the calledbut branch January 3, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants