Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violin plot table adjustments #4199

Merged
merged 10 commits into from
Mar 8, 2022
Merged

Conversation

adamabeshouse
Copy link
Contributor

Fixes cBioPortal/cbioportal#9297
Fixes cBioPortal/cbioportal#9323

Addresses desired changes in the x vs y violin plot table feature

Adam Abeshouse added 10 commits March 1, 2022 11:07
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
Signed-off-by: Adam Abeshouse <abeshoua@mskcc.org>
},
}),
q => {
return (
`Category:${q.chartInfo.categoricalAttr.clinicalAttributeId}/` +
`Numerical:${q.chartInfo.numericalAttr.clinicalAttributeId}/` +
`violinDomain:${JSON.stringify(q.chartInfo.violinDomain)}/` +
`violinLog:${q.violinLogScale}`
`violinLog:${q.violinLogScale}/` +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remind me what q is? why are making this bring string?

@alisman alisman merged commit c6d8a3b into cBioPortal:master Mar 8, 2022
@adamabeshouse adamabeshouse deleted the x-vs-y-changes branch March 8, 2022 15:27
@inodb inodb added the cl-prototype Prototype section in changelog. New features not ready for production use label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-prototype Prototype section in changelog. New features not ready for production use
Projects
None yet
3 participants