RFC68: Impl. structural variants table in Study View #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
changed the title
alisman
reviewed
Apr 11, 2023
| @@ -375,6 +388,17 @@ export type OncokbCancerGene = { | |||
| isCancerGene: boolean; | |||
| }; | |||
|
|
|||
| export type OncokbCancerStructVar = { | |||
There was a problem hiding this comment.
Not available from OncokbAPI? looping in @zhx828
There was a problem hiding this comment.
Also, if we must keep, lets put this in models folder
There was a problem hiding this comment.
I don't think we have Structural Variant class but AnnotateStructuralVariantQuery
There was a problem hiding this comment.
Also, if we must keep, lets put this in models folder
@alisman
Many types are defined in this Store (and in other stores): maybe better to create an issue for this and clean up the stores all at once, extracting relevant types?
alisman
reviewed
Apr 11, 2023
alisman
reviewed
Apr 11, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
src/pages/studyView/table/StructuralVariantMultiSelectionTable.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
src/pages/studyView/table/StructuralVariantMultiSelectionTable.tsx
Outdated
Show resolved
Hide resolved
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
alisman
reviewed
Apr 12, 2023
pvannierop
force-pushed
the
sv_table_in_study_view
branch
from
0311f26
to
3ef2e94
Compare
pvannierop
force-pushed
the
sv_table_in_study_view
branch
from
3ef2e94
to
9a1f2cf
Compare
alisman
reviewed
May 30, 2023
alisman
reviewed
May 30, 2023
alisman
reviewed
May 30, 2023
alisman
reviewed
May 30, 2023
alisman
reviewed
May 30, 2023
pvannierop
force-pushed
the
sv_table_in_study_view
branch
from
565232b
to
b41f347
Compare
BasLee
force-pushed
the
sv_table_in_study_view
branch
from
3646637
to
57f7d19
Compare
BasLee
force-pushed
the
sv_table_in_study_view
branch
6 times, most recently
from
cc3cea3
to
f6d32f9
Compare
BasLee
force-pushed
the
sv_table_in_study_view
branch
13 times, most recently
from
47af713
to
2444b1b
Compare
inodb
added
the
cl-prototype
BasLee
force-pushed
the
sv_table_in_study_view
branch
from
2444b1b
to
cf2dca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: cBioPortal/cbioportal#10119
RFC document: https://docs.google.com/document/d/1_nhO5dpjIGVbnBzch34keHgQUrxYEFudvFDsybDkgrA/edit
Can be activated using
?featureFlags=STUDY_VIEW_STRUCT_VAR_TABLEDescription
This PR will implement the Structural Variants table in Study View:
The Structural Variants table allows to define cohorts based on genomic structural variant events where a gene1 and/or gene2 position is defined.
Using the 'hiden checkbox' system gene1::gene2, gene1:: or ::gene2 structural variant queries can be staged for additional inspection in Results View:
