Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add PatientIdentifiers URL Parameter #4616

Conversation

haynescd
Copy link
Contributor

@haynescd haynescd commented May 9, 2023

Fix cBioPortal/cbioportal#10081

The Study View Page currently has a way to construct filterJSON URL with sample IDs:

https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"sampleIdentifiers":[{"studyId":"msk_impact_2017","sampleId":"P-0000004-T01-IM3"}]}

Update StudyViewPageStore to handle the following URL Parameter

JSON that is now supported within filterJson
{"patientIdentifiers": [{"studyId": "test_studyId", "patientId": "test_patientid"}]}

Ex:
https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"patientIdentifiers":[{"studyId":"msk_impact_2017","patientId":"P-0000004"}]}

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haynescd
Copy link
Contributor Author

haynescd commented May 9, 2023

@inodb Interesting.
https://cbioportal.org/study/summary?id=msk_impact_2017#filterJson={"sampleIdentifiers":[{"studyId":"msk_impact_2017","sampleId":"P-0000004-T01-IM3"}]}

This link produces the same outcome (sampleIdentifier Url Parameter). I can look into why all charts are not loaded.

@inodb
Copy link
Member

inodb commented May 9, 2023

Thanks @haynescd !

@haynescd haynescd force-pushed the feature/10081-Support-filter-urls-for-patientIds branch 2 times, most recently from cbb851d to 48d489a Compare May 9, 2023 20:04
@haynescd haynescd force-pushed the feature/10081-Support-filter-urls-for-patientIds branch from 48d489a to 1472e6c Compare May 9, 2023 20:21
@haynescd haynescd requested a review from alisman May 9, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants