Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline: links if event popover should open in new window when signaled #4643

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented Jun 13, 2023

By default, links show up in iframes. Some external websites do not allow themselves to be opened in iframes, so we must provide a way to open in new window. This behavior is turned on in the markdown with the ":blank" directive in the link text:

[PRSSMM:blank](https://www.hello.com)

image

@alisman alisman merged commit 7a4ad79 into cBioPortal:master Jun 14, 2023
6 of 7 checks passed
@inodb inodb added the genie label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants