Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsletter-btns-fixed #4890

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

SURAJ-SHARMA27
Copy link
Contributor

Fixes #10741

Describe changes proposed in this pull request:

  • Made distinct buttons for linkedin and google groups newsletter links as described in issue raised

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!
    Screenshot (18)

Any screenshots or GIFs?

bandicam.2024-04-11.00-11-16-908.mp4

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 2e97fa5
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6616db285eec190009416ba1
😎 Deploy Preview https://deploy-preview-4890--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman alisman merged commit ff03554 into cBioPortal:master Apr 10, 2024
10 of 12 checks passed
@inodb inodb added the gsoc label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants