Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study page clinical data tab: fix download after pagination change #4912

Merged
merged 1 commit into from
May 16, 2024

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented May 14, 2024

Fix cBioPortal/cbioportal#10794. Fix TSV download only containing data for the first 500 records, which was introduced by making the clinical data tab paginated. Download clinical data in batches of 25K

Copy link

netlify bot commented May 14, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 29fb40b
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6644d82455443800087c5bb4
😎 Deploy Preview https://deploy-preview-4912--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks so much!

@inodb inodb added the bug label May 15, 2024
@alisman alisman merged commit d1b6cd5 into cBioPortal:master May 16, 2024
13 of 15 checks passed
@alisman alisman deleted the fxPaginationDownload branch May 16, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants