Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run frontend localdb end2end tests in backend repo #3850

Closed
inodb opened this issue Feb 5, 2018 · 0 comments · Fixed by #6839
Closed

Run frontend localdb end2end tests in backend repo #3850

inodb opened this issue Feb 5, 2018 · 0 comments · Fixed by #6839
Assignees
Labels

Comments

@inodb
Copy link
Member

inodb commented Feb 5, 2018

Run the e2e localdb test in backend repo: https://github.com/cBioPortal/cbioportal-frontend/blob/master/.circleci/config.yml#L178. Currently in the frontend repo when you open a PR to the master branch, that frontend code is tested against a backend docker container running the latest master code. In the backend we would like the same thing but then testing the backend changes, that is:

  1. build a docker image for this backend (or get a war in some other way)
  2. find the frontend commit in pom.xml (https://github.com/cBioPortal/cbioportal/blob/master/pom.xml#L273)
  3. check that out and run the localdb e2e tests against the image from 1. No need to spin up a frontend separately, since that's bundled in the war from 1.

A previous attempt was made here: https://github.com/cBioPortal/cbioportal/pull/4124/files#diff-1d37e48f9ceff6d8030570cd36286a61R20. This include downloading the jar from jitpack which is no longer necessary, since we have a Docker container now for the backend. The previous attempt stalled, since it proved tricky to get the tests to pass. The remote e2e tests expected quite a heavy machine, with the CircleCI backend machine the same set of e2e tests would result in failures. This should no longer be a problem with the localdb tests, since in the frontend all the containers are running on CirlceCI infrastructure.

More comprehensive documentation about running the localdb tests e2e can be found here: https://github.com/cBioPortal/cbioportal-frontend#run-of-local-e2e-tests

@inodb inodb added the frontend label Feb 5, 2018
@inodb inodb removed the frontend label Nov 11, 2019
@inodb inodb changed the title Run frontend end2end tests in backend repo Run frontend localdb end2end tests in backend repo Nov 11, 2019
@inodb inodb added the devops label Nov 11, 2019
This was referenced Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants