Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-expression: should we overlap with mutaiton data or CNAs? #24

Open
jjgao opened this issue Mar 20, 2018 · 11 comments
Open

Co-expression: should we overlap with mutaiton data or CNAs? #24

jjgao opened this issue Mar 20, 2018 · 11 comments
Assignees

Comments

@jjgao
Copy link
Member

jjgao commented Mar 20, 2018

Currently, we are overlaying mutational data on top. I couldn't recall why we did that. Would it make more sense to overlay copy number data since CN may have a greater impact on expression?

image

@adamabeshouse
Copy link

adamabeshouse commented Mar 20, 2018

One option would be to do both: have checkboxes for Show Mutations and Show CNA, and if both are checked then color if either mutated or CNA, ie "KRAS altered, IPO8 altered, both altered, neither altered"

@tmazor
Copy link

tmazor commented Mar 20, 2018

Funny you should bring this up - I had a similar thought earlier today when looking at this page. I think we should have options for both. I had been thinking of a toggle like we have on the plots tab, but checkboxes like @adamabeshouse suggested would be even better. Or even better, we could also have an option to define a sample as altered according to the OQL used in the query.

@schultzn
Copy link

schultzn commented Mar 21, 2018 via email

@jjgao
Copy link
Member Author

jjgao commented Mar 21, 2018

For copy number, should we just use "altered or not"? Or differentiate between -2 and 2? What about -1 and 1?

@adamabeshouse
Copy link

@jjgao also what to consider altered if both mutation and CNA selected?

@schultzn
Copy link

schultzn commented Mar 21, 2018 via email

@adamabeshouse
Copy link

adamabeshouse commented Mar 21, 2018

@schultzn as-is I don't think the border will be visible enough for that, but maybe if we thickened it

another option is to use different shapes for mutation status, color for CNA. that may not be very easy to see though..

@schultzn
Copy link

schultzn commented Mar 21, 2018 via email

@adamabeshouse
Copy link

yes, I will post screenshots

@adamabeshouse
Copy link

it just occurred to me this only works in plots tab when the gene is the same, because otherwise which CNA do you show? in plots tab we only show CNA when the gene is the same.

@adamabeshouse
Copy link

@schultzn and I discussed and we're going to put this off

@jjgao jjgao transferred this issue from cBioPortal/cbioportal Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants