-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in datamanager.js getMutationProfileIds #1733
Fix bug in datamanager.js getMutationProfileIds #1733
Conversation
An example query which shows the problem / failure: (this query returns 2 mutations, but click the mutations tab and it shows "there are no mutations") |
})); | ||
fetch_promise.resolve( | ||
profiles | ||
.filter(function (p) {return p.genetic_alteration_type == "MUTATION_EXTENDED";}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it's better to use triple equalities in javascript, double equality does more fuzzy equalities. In this case I don't think it makes a difference but just as a rule I like to use triple equality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides == should be ===
1434ce9
to
6dbc3f8
Compare
Corrected equality operator |
- instead of returning all profile ids, add filter to only return mutation profiles
6dbc3f8
to
f1f0f76
Compare
datamanager.js has a function 'getMutationProfileIds' which was returning all retrieved profile ids rather than just the ids of mutation profiles. This was causing mutationmapper.js to not get mutation events if the first profile id returned was a copy number alternation profile (for example)
Changes proposed in this pull request:
note: we still need to add logic in the handler which starts mutationmapper to choose the "correct" mutation profile if there are more than one.
Checks
can be automatically added by git if you run the
git-commit
command withthe
-s
option)hotfix.
Notify reviewers
@onursumer @adamabeshouse @jjgao