Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the validator #4408

Merged
merged 3 commits into from Jul 10, 2018
Merged

Updates to the validator #4408

merged 3 commits into from Jul 10, 2018

Conversation

sandertan
Copy link
Contributor

@sandertan sandertan commented Jun 28, 2018 •
edited

This PR adds 3 updates to the validator:

  • Validate the length of attributes in meta_study.txt
  • Fix bug in extracting study id in validateStudies
  • Update MAF checks to support larger INS and DEL events

Update MAF checks to support larger INS and DEL events

This fixes:

screen shot 2018-06-28 at 12 52 12

I also added test data to validate that these variants are valid:

  • G, G, -> CA
  • CA, CA -> G

@sandertan sandertan force-pushed the validator_update_maf_checks branch from 02fbfcc to b6267d4 Compare July 10, 2018 09:08
@sandertan sandertan changed the title Update MAF checks to support larger INS and DEL events Updates to the validator Jul 10, 2018
@ritikakundra ritikakundra merged commit 1005e9c into cBioPortal:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yichaoS yichaoS yichaoS approved these changes

@ritikakundra ritikakundra Awaiting requested review from ritikakundra

Assignees

@yichaoS yichaoS

@sandertan sandertan

@ritikakundra ritikakundra

Labels
bug validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandertan @yichaoS @ritikakundra