Added spring profiles for redis and ehcache #7696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mandawilson
commented
Jul 16, 2020
mandawilson
commented
- Updated ip addresses for redis servers
- Changed ttl to 0 and added comments
- Added spring profiles for redis and ehcache
9 tasks
sheridancbio
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Merging this code to allow further development in the feature branch. Some features still need to be adapted, and maybe the use of spring profiles will be examined / tested. But this also includes the naming of caches based on app-types and other configuration improvements.
| @@ -344,22 +344,22 @@ This gene set will add the following in the query box: | |||
| # Ehcache Settings | |||
| cBioPortal is supported on the backend with Ehcache. The configuration, size, and location of these caches are configurable from within portal.properties through the following properties. | |||
|
|
|||
| The cache type is set using `ehcache.cache_type`. Valid values are `none`, `heap` (heap-only), `disk` (disk-only), and `hybrid` (disk + heap). By default, `ehcache.cache_type` is set to `none` which disables the cache. When the cache is disabled, no responses will be stored in the cache. | |||
| The cache type is set using `persistence.cache_type`. Valid values are `no-cache`, `redis` (redis), `ehache-heap` (ehcache heap-only), `ehache-disk` (ehcache disk-only), and `ehache-hybrid` (ehcache disk + heap). By default, `persistence.cache_type` is set to `no-cache` which disables the cache. When the cache is disabled, no responses will be stored in the cache. | |||
There was a problem hiding this comment.
typos : ehache-heap, ehache-disk, ehache-hybrid
we can fix this in a follow up PR
| EhCacheStatistics is autowired, and requires a javax.cache.CacheManager | ||
| so all (or most) of these beans need to be created even if ehcache is not running | ||
| --> | ||
| <!--beans profile="ehcache-disk,ehcache-heap,ehcache-hybrid"--> |
There was a problem hiding this comment.
we still need to work these beans out
| <bean id="customKeyGenerator" class="org.cbioportal.persistence.util.CustomKeyGenerator"/> | ||
|
|
||
| <!--bean id="ehCacheStatistics" class="org.cbioportal.persistence.util.EhCacheStatistics"> |
There was a problem hiding this comment.
we need to work out the wiring of a cache statistics service (maybe a stub) for redis
averyniceday
pushed a commit
to averyniceday/cbioportal
that referenced
this pull request
Oct 19, 2020
* updated ip addresses for redis servers * changed ttl to 0 and added comments * added spring profiles for redis and ehcache
sheridancbio
pushed a commit
to sheridancbio/cbioportal
that referenced
this pull request
Oct 19, 2020
* updated ip addresses for redis servers * changed ttl to 0 and added comments * added spring profiles for redis and ehcache
averyniceday
pushed a commit
to averyniceday/cbioportal
that referenced
this pull request
Dec 7, 2020
* updated ip addresses for redis servers * changed ttl to 0 and added comments * added spring profiles for redis and ehcache
averyniceday
pushed a commit
to averyniceday/cbioportal
that referenced
this pull request
Jan 6, 2021
* updated ip addresses for redis servers * changed ttl to 0 and added comments * added spring profiles for redis and ehcache
averyniceday
pushed a commit
to averyniceday/cbioportal
that referenced
this pull request
Jan 6, 2021
* updated ip addresses for redis servers * changed ttl to 0 and added comments * added spring profiles for redis and ehcache
averyniceday
pushed a commit
to averyniceday/cbioportal
that referenced
this pull request
Jan 6, 2021
* updated ip addresses for redis servers * changed ttl to 0 and added comments * added spring profiles for redis and ehcache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.