Update fetchGenericAssayDataCounts endpoint #8881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for single chart filtering operation
dippindots
force-pushed
the
update-generic-assay-count
branch
from
ac8be15
to
771f380
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Luke-Sikina
approved these changes
Sep 2, 2021
alisman
reviewed
Sep 8, 2021
| @@ -508,6 +508,12 @@ private void init() { | |||
|
|
|||
| List<GenericAssayDataFilter> gaFilters = interceptedGenericAssayDataCountFilter.getGenericAssayDataFilters(); | |||
| StudyViewFilter studyViewFilter = interceptedGenericAssayDataCountFilter.getStudyViewFilter(); | |||
| // when there is only one filter, it means study view is doing a single chart filter operation | |||
There was a problem hiding this comment.
why is this not also necessary when there are more than one filters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
/generic-assay-data-counts/fetchendpoint to correct data count for single chart filtering operationIn the study view page, we fetch single chart for calling
/generic-assay-data-counts/fetchagain, and at this time, we do not want to get filtered data count from that endpoint. We want to get original data count without filtering, because we want to show unselected portion of the chart, this change it to update this logic.Note: this endpoint is in development, there is no frontend usage right now.