Fix: Downscale claim staying in pending #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Whisper40
requested changes
Nov 10, 2023
changed some variables name to fit coding style Co-authored-by: Kévin PEREZ <30440458+Whisper40@users.noreply.github.com>
leoarpin
force-pushed
the
fix-downscale-pending
branch
from
a8456cc
to
e2c1ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug concerning Downscale Quotaclaim that were staying infinitly in PENDING status.
The bug was that nothing was re running the claims that had been set to pending. PENDING claims were staying in pending even after someone deleted a pod. The claims were just never re evaluated.
Fixed it by adding an Informer that looks at pods in namespace. Requeue all claims that are pending to be re-evaluated on every pod update inside the namespace.