Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix score #295

Merged
merged 1 commit into from
May 23, 2024
Merged

fix score #295

merged 1 commit into from
May 23, 2024

Conversation

iiiidaaa
Copy link
Contributor

cloudsploitのスコア修正を行います

Copy link

PR Analysis

Main theme

Bug fix

PR summary

Summarize the PR in 2-3 sentences.

Type of PR

Bug fix

PR Feedback:

General suggestions

Offer general feedback and suggestions for the contributors and maintainers of this PR. This may encompass recommendations regarding the overall structure, primary purpose, best practices, critical bugs, and other aspects of the PR. Please avoid addressing the PR title and description or the absence of tests. Explain your suggestions.

Code feedback

  • file: pkg/cloudsploit/plugin_finding_map.go
    • suggestion: Consider ensuring consistency in scoring for "webServerPublicAccess" category by setting its score to 8.0 as it was before.
    • relevant line:
      +	categoryMWAA + "/webServerPublicAccess":               {Score: 3.0, Tags: []string{}},
      

Security concerns

no

Copy link

セキュリティレビューを実施しました。
特に問題は見つかりませんでした👏

By RISKEN review

Copy link
Collaborator

@gassara-kys gassara-kys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iiiidaaa iiiidaaa merged commit a2fe4e3 into master May 23, 2024
5 checks passed
@iiiidaaa iiiidaaa deleted the fix-cloudsploit-score branch May 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants