Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: AI Summary API with streaming #338

Merged
merged 3 commits into from
Sep 26, 2023
Merged

add: AI Summary API with streaming #338

merged 3 commits into from
Sep 26, 2023

Conversation

gassara-kys
Copy link
Collaborator

@gassara-kys gassara-kys commented Sep 25, 2023

OpenAIのServer-Side StreamingAPIを実装します。
UnaryAPIの実装は残しますがすべて置き換える場合にはUnary側は削除するかもしれません。

Makefile Outdated
get-ai-summary-stream:
$(GRPCURL) \
-plaintext \
-d '{"project_id":1001, "finding_id": 17730, "lang":"ja"}' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finding_idにデバッグ中の値が入ってそうです。
他と揃えて1001とかでも良いかなと思いました。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正します!

Copy link
Contributor

@iiiidaaa iiiidaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gassara-kys gassara-kys merged commit 2648270 into master Sep 26, 2023
3 checks passed
@gassara-kys gassara-kys deleted the open-ai-streaming branch September 26, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants