Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete http endpoint #352

Merged
merged 2 commits into from
Jan 25, 2024
Merged

chore: delete http endpoint #352

merged 2 commits into from
Jan 25, 2024

Conversation

senk8
Copy link
Contributor

@senk8 senk8 commented Jan 22, 2024

概要

grpc_probeが使えるようになったため、readiness probeのために作成していたHTTPヘルスチェックエンドポイントを削除します。

チェックポイント

  • 余計なものを削除していないか

参考資料

https://kubernetes.io/blog/2022/05/13/grpc-probes-now-in-beta/
https://github.com/ca-risken/internal-community/issues/615

Copy link

セキュリティレビューを実施しました。
特に問題は見つかりませんでした👏

By RISKEN review

@senk8 senk8 marked this pull request as ready for review January 23, 2024 09:51
@senk8 senk8 requested a review from iiiidaaa January 23, 2024 09:52
Copy link
Contributor

@iiiidaaa iiiidaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gassara-kys gassara-kys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senk8 senk8 merged commit 2b27f76 into master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants