add put-alert-first-viewed-at #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
セキュリティレビューを実施しました。 By RISKEN review |
gassara-kys
reviewed
Mar 15, 2024
pkg/server/project/project.go
Outdated
|
|
||
| for name, actionPtn := range map[string]string{projectAdmin: ".*", projectViewer: "/finding/.+", findingEditor: "get|list|is-admin|/finding/.+"} { | ||
| for name, actionPtn := range map[string]string{projectAdmin: ".*", projectViewer: viewerActionPtn, findingEditor: viewerActionPtn + "|/finding/.+"} { |
There was a problem hiding this comment.
本件、LGTMなんですが、
すいません、前回のPRの指摘したような気もするのですが、finding-editorは、/finding/ に加えて /alert/ の操作全般も要件に入っていた気がします。（↓）
アラートの pending, archive 実行権限
こちら確認お願いしてもいいでしょうか？
There was a problem hiding this comment.
alertとfindingの区別を誤解していました。修正しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put-alert-first-viewed-atの権限がないと、alertとfindingの画面を開くことができなかったので修正しました。また、viewer権限が間違っていたので修正しました。
動作確認済み
実際にfindingが開くことが可能かどうかはローカルで管理者以外のユーザーを作成してそれにログインする方法がわからなかったため、試せていません。方法をご存知でしたらご教示ください。