Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yaml for ci #358

Merged
merged 1 commit into from
Apr 1, 2024
Merged

add yaml for ci #358

merged 1 commit into from
Apr 1, 2024

Conversation

senk8
Copy link
Contributor

@senk8 senk8 commented Apr 1, 2024

コードレビュー効率化のため、code-butlerを導入します。以下の参考yamlのコピペです。
https://github.com/marketplace/actions/code-butler-for-pr-review

Copy link

github-actions bot commented Apr 1, 2024

セキュリティレビューを実施しました。
特に問題は見つかりませんでした👏

By RISKEN review

@senk8
Copy link
Contributor Author

senk8 commented Apr 1, 2024

/review

@senk8
Copy link
Contributor Author

senk8 commented Apr 1, 2024

issue_commentは以下の条件より、masterにマージされた後にしかトリガーされない。そのため、動作確認はマージ後に行います。

注: このイベントは、ワークフローファイルがデフォルト ブランチにある場合にのみワークフローの実行をトリガーします。
https://docs.github.com/ja/actions/using-workflows/events-that-trigger-workflows#issue_comment

Copy link
Collaborator

@gassara-kys gassara-kys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senk8 senk8 merged commit 2e3fcbb into master Apr 1, 2024
4 checks passed
@senk8
Copy link
Contributor Author

senk8 commented Apr 1, 2024

/review

Copy link

github-actions bot commented Apr 1, 2024

PR Analysis

Main theme

type: string
description: "Adding a GitHub Actions workflow file for a Code Butler bot."

PR summary

type: string
description: "This PR adds a GitHub Actions workflow file named 'code-butler.yml' for a Code Butler bot. The workflow defines jobs triggered by specific comments in issues for performing code reviews and enabling a chat feature."

Type of PR

type: string
enum:
- Enhancement

PR Feedback:

General suggestions

Provide feedback on the overall structure and purpose of the workflow file. Ensure that the triggers and actions specified align with the intended functionality of the Code Butler bot.

Code feedback

  • relevant file: /.github/workflows/code-butler.yml
    suggestion: "Consider adding error handling mechanisms in the workflow steps to manage potential failures or exceptions that may occur during code review or chat processes."
    relevant line:
    •      - uses: ca-dp/code-butler@v1
      

Security concerns:

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants