-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gumroad API Break Changes #33
Comments
This commit introduces breaking changes to the `Product` struct & `NewProduct` func: * Deprecated the **Product** field in the `Product` struct. * Added **ID** field in the `Product` struct as replacement for **Product** field. * Updated the `NewProduct` function to accept & use product ID instead of the product permalink[^1]. * Modified the `VerifyWithContext` method to use **product_id**[^1] parameter instead of **product_permalink** in the API req body. Fix caarlos0#33 [^1]: https://help.gumroad.com/article/76-license-keys#verification Signed-off-by: Dwi Siswanto <me@dw1.io>
it seems it depends on the product, tested one of mine, still working
so just changing the lib to use product_id instead doesn't seem like a good idea Maybe changing |
Agree with this.
I think it is. Product ID only needed for "products created on or after Jan 9, 2023." |
Originally posted by @dwisiswant0 in #32 (comment)
Turns out, it doesn't work:
Gumroad Notice: https://help.gumroad.com/article/76-license-keys#verification
The text was updated successfully, but these errors were encountered: