Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the crash when gc_interval is not set #183

Merged
merged 3 commits into from
Jan 14, 2023
Merged

fix the crash when gc_interval is not set #183

merged 3 commits into from
Jan 14, 2023

Conversation

dongfuye
Copy link
Contributor

@dongfuye dongfuye commented Jan 13, 2023 •
edited
Loading

Fix issue #182

@cabol
Copy link
Owner

cabol commented Jan 13, 2023 •
edited
Loading

LGTM but please run the mix format with Elixir 1.14.x. Overall, try to run mix check with the latest Elixir version (1.14.x) and OTP 25.x, so you can maybe address these issues locally and fix the CI.

This is also related to #181 (perhaps may be a fix for it)

Thanks for the fix 👍

@coveralls
Copy link

coveralls commented Jan 13, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling 66eb2d1 on dongfuye:master into 53e570d on cabol:master.

@cabol cabol merged commit 1da2129 into cabol:master Jan 14, 2023
@cabol cabol mentioned this pull request Jan 14, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabol cabol cabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongfuye @cabol @coveralls