Partitioned Adapter supports two-item tuples as keys #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem that `get_all` when asking for a two element tuple key (ie
`{"foo", 1}) would only consider the first element of the tuple to be the key,
and therefore may ask for the data on the wrong node. This seems to have been
done to support put_(new_)all which puts the key in the first element and values in
the second.
I've passed along the action to the `group_keys_by_node` function so we're able
to know which structure to expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for Nebulex!
We've run into a problem using
get_allwhen asking for two-item tuple keys (ie{"foo", 1}). The partitioned adapter would only consider the first element of the tuple to be the key, and therefore may ask for the data on the wrong node. This seems to have been done to supportput_(new_)allwhich puts the key in the first element and values in the second.I've passed along the action to the
group_keys_by_nodefunction so we're able to know which structure to expect in the enum.