Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip subscriber verification #1990

Closed
karthik-22feb opened this issue Jul 19, 2016 · 4 comments
Closed

Skip subscriber verification #1990

karthik-22feb opened this issue Jul 19, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@karthik-22feb
Copy link

Hi Team,

I am using the CACHE ( 2.3.0-RC4) version. & am trying to skip the CONFIRM SUBSCRIPTION when an user subscribes to the system

I would really appreciate if you can provide a solution to my issue?

Let me know about your thoughts.

Thanks,
Karthik

@jbrooksuk
Copy link
Member

jbrooksuk commented Jul 19, 2016

We don't have an option for turning off subscription confirmations, but that would be something we could easily add.

Ping @joecohens.

Also, you're running an outdated version of Cachet, the latest version is v2.3.6 :)

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jul 19, 2016
@karthik-22feb
Copy link
Author

Hi jbrooksuk,

The Confirm Subscription feature is already available in the system. I receive an Confirm Subscription email when i subscribe to the updates .

I wish to turn off this feature. I want people to sign up the the updates without confirming their email address.

I tried to set Binput::get('verify', false), in the below code located in app/Http/Controllers/Api/SubscriberController.php but it did not work

public function postSubscribers()
{
try {
$subscriber = dispatch(new SubscribeSubscriberCommand(
Binput::get('email'),
Binput::get('verify', false),
Binput::get('components', null)
));
} catch (QueryException $e) {
throw new BadRequestHttpException();
}

    return $this->item($subscriber);
}

@jbrooksuk
Copy link
Member

Sorry, I re-worded my reply. It's very hot here today and I'm not with it :)

@jbrooksuk jbrooksuk changed the title SKIP CONFIRM SUBSCRIPTION Skip subscib Jul 20, 2016
@jbrooksuk jbrooksuk changed the title Skip subscib Skip subscriber verification Jul 20, 2016
@jbrooksuk
Copy link
Member

This is now done in v2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants