python: allow venv to be used in recursive devenv #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvanderlinden
force-pushed
the
pr-python-recursive-devenv
branch
from
8c0f782
to
524e6ac
Compare
bobvanderlinden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever you have a project structure like:
And you navigate into subproject, you'll get both environment variables from the root and from subproject. This works surprisingly well, however venv doesn't.
It seems as if
DEVENV_ROOTfrom the subproject is being concatenated toDEVENV_ROOTof the parent project by envrc.To circumvent this venv should stop relying on the runtime DEVENV_ROOT and DEVENV_PROFILE and start relying on the variable from Nix.