use util-linuxMinimal instead of util-linux for column #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the util-linux package is used for the column cli. This is the only dependency for which util-linux is used. It results in quite a significant addition to the closure size. util-linuxMinimal is somewhat smaller and also includes the column command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the util-linux package is used for the column cli. This is the only dependency for which util-linux is used. It results in quite a significant addition to the closure size.
util-linuxMinimal is somewhat smaller and also includes the column command.
I used
nix-treeto check the closure size of the devenv command:Before:
After:
It is still big, but at least it is smaller 馃槄
Since python is already part of the closure, it might be a good idea to base everything on python and remove dependencies on util-linux-minimal, findutils, coreutils and jq.
This could help CI builds quite a bit in reducing the time it takes to fetch devenv.sh.