Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix devcontainer #482

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix devcontainer #482

merged 1 commit into from
Mar 13, 2023

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Mar 12, 2023 •
edited

Fixed #171

@domenkozar domenkozar mentioned this pull request Mar 12, 2023
Closed
@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 12, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0317938
Status: ✅  Deploy successful!
Preview URL: https://faef90ac.devenv.pages.dev
Branch Preview URL: https://fix-devcontainer.devenv.pages.dev

View logs

@shyim
Copy link
Contributor

shyim commented Mar 12, 2023 •
edited

Looks good but can you preconfigure direnv for bash/zsh/fish?

@shyim
Copy link
Contributor

shyim commented Mar 12, 2023

Like this https://github.com/gitpod-io/workspace-images/blob/646394045ce61da68a236b9b6da61b12079358ec/chunks/tool-nix/Dockerfile#L37-L42

The path for GitHub to whitelist would be /workspaces

@domenkozar domenkozar merged commit 2ef261d into main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Devcontainer not working for devenv development
2 participants
@domenkozar @shyim