refactor(dotnet): add package option and needed environment variables #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratsclub
commented
Mar 15, 2023
|
|
||
| package = lib.mkOption { | ||
| type = lib.types.package; | ||
| default = pkgs.dotnetCorePackages.sdk_7_0; |
There was a problem hiding this comment.
According to the manual:
dotnetCorePackages.sdkcontains both a runtime and the full sdk of a given version
Should be a good default package, however, we don't have a generic dotnetCorePackages.sdk package pointing to the latest release. This is why I set 7.0 as the default one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
packageoptionicupackage on theLD_LIBRARY_PATHfor globalization