Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use miliseconds when creating shell in case we launch two #493

Merged
merged 1 commit into from
Mar 16, 2023
Merged

use miliseconds when creating shell in case we launch two #493

merged 1 commit into from
Mar 16, 2023

Conversation

domenkozar
Copy link
Member

No description provided.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56ac2cb
Status: ✅  Deploy successful!
Preview URL: https://8faf1f3c.devenv.pages.dev
Branch Preview URL: https://two-shells.devenv.pages.dev

View logs

bobvanderlinden
bobvanderlinden approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@bobvanderlinden bobvanderlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is an improvement. Avoiding conflicts altogether would require a bigger change.

@bobvanderlinden
Copy link
Contributor

Hmm, CI fails, but seems unrelated NixOS/nix#7242

@domenkozar domenkozar merged commit 3dfc678 into main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvanderlinden bobvanderlinden bobvanderlinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@domenkozar @bobvanderlinden