devenv: use poetry instead of requirements.txt #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently requirements.txt is used. It is installed in enterShell. This has 2 downsides: - Loading devenv shell takes a longer time, because pip install reruns every time the devenv shell is entered. - The dependencies that are installed are not locked. The latest version is chosen, which will result in differences in tooling for different people. devenv docs from the past might not be reproducible. The biggest downside I have seen is that the files are larger in size. Though I might be biased to using poetry vs pip directly.
shyim
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently requirements.txt is used within devenv's devenv.nix. It is installed in
enterShell. This has 2 downsides that I found:The biggest downside I have seen is that the files are larger in size. I might be biased to using poetry vs pip directly and not seeing more of the downsides 馃槄