feat: add HashiCorp Vault service #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
requested changes
May 1, 2023
|
Thanks a lot for contributing this! I'd ask you to write a basic test to assert value has started, using a special file named |
… server has started
domenkozar
reviewed
May 1, 2023
seems like it needs a bit more tweaking, almost there! |
|
Yes, I suspect there is some race condition with the test script, as it passes on both the macOs platform tests. |
…for service startup
|
I've pushed a change that will hopefully give better info if the test fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.