python: poetry: add groups and extras options #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sersorrel @mirkolenz could you have a look? |
|
@bobvanderlinden Thank you for creating this PR! I especially like the fact that you incorporated the generated install command into the hash 馃槃 |
|
Np 馃槃 Since I'm not using it at the moment, let me whether you run into problems |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #621
This adds two options.
groups = [ <group> ]is the equivalent of usingpoetry install --with <group>.It only supports adding groups, as I have not looked into supporting
--onlynor--without. Maybe someone else could give an opinion of this, as I have never used these cli options before 馃槄.extras = [ <extra> ]is the equivalent of usingpoetry install --extras <extra>.I have now also made sure that the command line option of
poetry installare included in the checksum that determines whetherpoetry installshould be re-run. If any of the arguments changes, it will run poetry install the next time devenv shell initializes.