Make postgres initialDatabases schema creation more robust #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stig
commented
Jun 14, 2023
stig
force-pushed
the
postgres-schemas
branch
4 times, most recently
from
08538cd
to
eea5a4d
Compare
stig
changed the title
stig
changed the title
The quotes around the "*.sql" glob prevented cat from expanding it,
leading to this error:
14:55:40 postgres.1 | cat: '/nix/store/k30kwm1p6zn23ml95q1ldrykbi1v99qr-sql/*.sql': No such file or directory
Instead read migration files in version order (with ls -v), and use a
shell loop to concatenate them.
Say we have two schema files:
v1_create_foo.sql (note missing ; at the end)
CREATE TABLE foo (id varchar)
v2_create_bar.sql:
CREATE TABLE bar (id varchar);
If we simply cat together all the schema files we get an error because
of the missing ;, but by applying the migrations one at a time we
handle this situation.
Without -j statements are terminated at ";" followed by newline. This
frequently fails for files creating plpgsql functions like this
example, because it tries to execute it as 4 separate statements:
CREATE FUNCTION truncate_all() RETURNS void AS $$
BEGIN
TRUNCATE foo;
TRUNCATE bar;
END;
$$ LANGUAGE plpgsql;
Even with -j statements are terminated after ";" followed by two
newlines, which fails on files like this because it tries to execute
it as 4 separate statements, which results in an error:
CREATE FUNCTION truncate_all() RETURNS void AS $$
BEGIN
TRUNCATE foo;
TRUNCATE bar;
END;
$$ LANGUAGE plpgsql;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project with ~150 migration files going back to 2016, added by many different people using different conventions. The commits in this PR are required in order for me to successfully apply all those sql files.
The repo is private (sorry!), but I've tried to give a representative example of each fix in its commit message.