Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local paths in hoogle point to /opt/nix #21

Closed
fiadliel opened this issue Feb 12, 2020 · 8 comments 路 Fixed by #23
Closed

Local paths in hoogle point to /opt/nix #21

fiadliel opened this issue Feb 12, 2020 · 8 comments 路 Fixed by #23
Assignees
Labels
bug Something isn't working

Comments

@fiadliel
Copy link

When hoogle documentation (I'm invoking from haskell.nix) is built with this action, the resulting hoogle database contains paths to /opt/nix instead of /nix. This is the obvious direct culprit 馃槩

I've only validated this on the MacOS platform, so I'm not certain if it's also true for Linux (but the symlinking appears to be performed on both platforms).

I'll look into whether this is caused inside hoogle, or the hoogle.nix integration, but either way, it's more than concerning that the symlink causes a modified build.

@fiadliel
Copy link
Author

Okay, I see at NixOS/nix#3212 that it's known that the symlink approach is impure. For now, we can either stop building hoogle databases with this, or make a symlink from /opt/nix to /nix on other machines (where they use the volume approach).

This ticket may still have value to you, as it's a concrete example of impurities caused by the symlink approach in haskell builds.

@domenkozar
Copy link
Member

I'd like to move away from symlink approach, but I'm not sure upstream has come to a better solution yet. Maybe @LnL can jump in :)

@domenkozar domenkozar added the bug Something isn't working label Feb 13, 2020
@LnL7
Copy link

LnL7 commented Feb 13, 2020

Yeah, I updated that pr to create an apfs volume. Take a look at create-darwin-volume.sh.

@domenkozar
Copy link
Member

Could someone test with:

- uses: cachix/install-nix-action@releases/v7

before I make a release fixing this?

cc @nomeata

@fiadliel
Copy link
Author

@domenkozar It installed and worked correctly for me. I don't know whether this might be useful to add, but it probably wouldn't hurt (no idea if Spotlight is running on the build machines):
mdutil -i off /nix
(as found at NixOS/nix#2925 (comment))

In any case, thanks a lot for working on this!

nomeata added a commit to dfinity/motoko that referenced this issue Feb 25, 2020
@nomeata
Copy link

nomeata commented Feb 25, 2020

Yes, works here as well. Thanks!

@domenkozar
Copy link
Member

domenkozar commented Feb 26, 2020

Don't forget to switch to @v7 once it's released, hopefully today or tomorrow.

@fiadliel thanks for the tip!

EDIT: I'll leave it open until release.

@domenkozar domenkozar reopened this Feb 26, 2020
@domenkozar
Copy link
Member

Released v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants