Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: make sure webui fetches all assets from the ovpm http server #65

Closed
cad opened this issue Apr 3, 2018 · 0 comments
Closed

webui: make sure webui fetches all assets from the ovpm http server #65

cad opened this issue Apr 3, 2018 · 0 comments
Assignees
@cad
Labels
enhancement
Milestone
v0.3

Comments

@cad
Copy link
Owner

cad commented Apr 3, 2018 •
edited

Fetching assets from outside cdns should be avoided.
@cad cad added the enhancement label Apr 3, 2018
@cad cad added this to the v0.3 milestone Apr 3, 2018
@cad cad self-assigned this Apr 3, 2018
cad added a commit that referenced this issue Apr 4, 2018
@cad
feat(webui): ensure assets are fetched from the OVPM HTTP server only
34fe513 
Previously we were fetching the necessary webui libraries such as bootstrap
and mui css, from the CDN for the sake of bandwidth and round-trip time.

But now we have decided to serve these assets from the OVPM server itself for
better integrity and protection against
information leaks such as IP address of the user agent to the 3rd party CDN
services.

Closes #65
@cad cad closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cad cad

Labels
enhancement
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@cad