Skip to content

Commit

Permalink
rewrite: strip_prefix, strip_suffix, and uri_replace dirs (closes #2906)
Browse files Browse the repository at this point in the history
  • Loading branch information
mholt committed Dec 12, 2019
1 parent 5e9d81b commit b1a456c
Show file tree
Hide file tree
Showing 2 changed files with 95 additions and 3 deletions.
3 changes: 3 additions & 0 deletions caddyconfig/httpcaddyfile/directives.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ import (
// to apply directives in HTTP routes.
var defaultDirectiveOrder = []string{
"rewrite",
"strip_prefix",
"strip_suffix",
"uri_replace",
"try_files",
"basicauth",
"headers",
Expand Down
95 changes: 92 additions & 3 deletions modules/caddyhttp/rewrite/caddyfile.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,25 @@
package rewrite

import (
"strconv"

"github.com/caddyserver/caddy/v2/caddyconfig/httpcaddyfile"
"github.com/caddyserver/caddy/v2/modules/caddyhttp"
)

func init() {
httpcaddyfile.RegisterHandlerDirective("rewrite", parseCaddyfile)
httpcaddyfile.RegisterHandlerDirective("rewrite", parseCaddyfileRewrite)
httpcaddyfile.RegisterHandlerDirective("strip_prefix", parseCaddyfileStripPrefix)
httpcaddyfile.RegisterHandlerDirective("strip_suffix", parseCaddyfileStripSuffix)
httpcaddyfile.RegisterHandlerDirective("uri_replace", parseCaddyfileURIReplace)
}

// parseCaddyfile sets up the handler from Caddyfile tokens. Syntax:
// parseCaddyfileRewrite sets up a basic rewrite handler from Caddyfile tokens. Syntax:
//
// rewrite [<matcher>] <to>
//
// The <to> parameter becomes the new URI.
func parseCaddyfile(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
func parseCaddyfileRewrite(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
var rewr Rewrite
for h.Next() {
if !h.NextArg() {
Expand All @@ -42,3 +47,87 @@ func parseCaddyfile(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error)
rewr.Rehandle = true
return rewr, nil
}

// parseCaddyfileStripPrefix sets up a handler from Caddyfile tokens. Syntax:
//
// strip_prefix [<matcher>] <prefix>
//
// The request path will be stripped its prefix if it matches <prefix>.
func parseCaddyfileStripPrefix(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
var rewr Rewrite
for h.Next() {
if !h.NextArg() {
return nil, h.ArgErr()
}
rewr.StripPathPrefix = h.Val()
if h.NextArg() {
return nil, h.ArgErr()
}
}
return rewr, nil
}

// parseCaddyfileStripSuffix sets up a handler from Caddyfile tokens. Syntax:
//
// strip_suffix [<matcher>] <suffix>
//
// The request path will be stripped its suffix if it matches <suffix>.
func parseCaddyfileStripSuffix(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
var rewr Rewrite
for h.Next() {
if !h.NextArg() {
return nil, h.ArgErr()
}
rewr.StripPathSuffix = h.Val()
if h.NextArg() {
return nil, h.ArgErr()
}
}
return rewr, nil
}

// parseCaddyfileURIReplace sets up a handler from Caddyfile tokens. Syntax:
//
// uri_replace [<matcher>] <find> <replace> [<limit>]
//
// Substring replacements will be performed on the request URI up to the
// number specified by limit, if any (default = 0, or no limit).
func parseCaddyfileURIReplace(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
var rewr Rewrite

var repls []replacer

for h.Next() {
args := h.RemainingArgs()
var find, replace, lim string
switch len(args) {
case 3:
lim = args[2]
fallthrough
case 2:
find = args[0]
replace = args[1]
default:
return nil, h.ArgErr()
}

var limInt int
if lim != "" {
var err error
limInt, err = strconv.Atoi(lim)
if err != nil {
return nil, h.Errf("limit must be an integer; invalid: %v", err)
}
}

repls = append(repls, replacer{
Find: find,
Replace: replace,
Limit: limInt,
})
}

rewr.URISubstring = repls

return rewr, nil
}

0 comments on commit b1a456c

Please sign in to comment.