Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fuzz: add more fuzz targets #4105

Merged
merged 1 commit into from
Apr 8, 2021
Merged

ci: fuzz: add more fuzz targets #4105

merged 1 commit into from
Apr 8, 2021

Conversation

mohammed90
Copy link
Member

I'm prepping to bring back the continuous fuzzing of Caddy on another platform after the departure of FuzzIt. In the process, I found more possible targets that can be included based on the criteria of:

  • accept string|[]byte as input
  • function body is more than mere json.Unmarshal

One dilemma for now is where to store the seed corpus to be retrieved by the new platform. Any thoughts? I think some projects store them in a branch, but not sure how much of a hassle will it be to keep that branch updated. I've considered hiding them behind a refs/<something>/corpus, but it feels too magical and needs insider knowledge.

@mohammed90 mohammed90 changed the title ci: fuzz: add more fuzz target ci: fuzz: add more fuzz targets Apr 4, 2021
@francislavoie
Copy link
Member

francislavoie commented Apr 4, 2021

I think a fuzz-corpus branch, or a separate repo, if possible, would be ok.

I don't have much else to add on this topic 🤷‍♂️ this looks fine to me.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks as usual @mohammed90 🙂

As for where to store the corpus, a branch sounds good to me also. Would it get very large though? If so, maybe a separate repo, in a (possibly vain) attempt to keep this repo as lean as possible.

@mohammed90
Copy link
Member Author

LGTM, thanks as usual @mohammed90 🙂

As for where to store the corpus, a branch sounds good to me also. Would it get very large though? If so, maybe a separate repo, in a (possibly vain) attempt to keep this repo as lean as possible.

It won't be the generated corpus. It'll just contain the seeds and the corpus I extracted from Fuzzit before its demise. Going with a branch, I'll do something like git checkout --orphan fuzz-seed-corpus and commit only the seed .zip files.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's see if it helps! Thanks!

@mholt mholt merged commit 03b5deb into master Apr 8, 2021
@mholt mholt deleted the more-fuzz-targets branch April 8, 2021 17:45
@francislavoie francislavoie added this to the v2.4.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants