Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build and test on Go 1.17, bump minimum to 1.16 #4283

Merged
merged 1 commit into from
Aug 17, 2021
Merged

ci: Build and test on Go 1.17, bump minimum to 1.16 #4283

merged 1 commit into from
Aug 17, 2021

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie commented Aug 16, 2021

Used #4024 as a template. Pretty much the same change, different versions.

@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Aug 16, 2021
@francislavoie francislavoie added this to the v2.4.4 milestone Aug 16, 2021
@francislavoie
Copy link
Member Author

francislavoie commented Aug 16, 2021

FYI @mholt just before merging, the repo should be updated to make the 1.17 jobs required, and make the 1.15 job no longer required.

@francislavoie francislavoie changed the title Start testing on Go 1.17, drop 1.15 ci: Build and test on Go 1.17, bump minimum to 1.16 Aug 16, 2021
@francislavoie
Copy link
Member Author

francislavoie commented Aug 16, 2021

To be considered: should we start building for Windows ARM64, or at least add it to the cross-build test? https://github.com/goreleaser/goreleaser/pull/2144/files

Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is successful and nothing in the release notes (https://golang.org/doc/go1.17) impacts the go.{mod,sum} files to where the project won't build. Thanks for tackling this, Francis!

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required CI checks have been updated to shift out 1.15 for 1.17.

@francislavoie We have had several requests for Windows ARM 64, so we should consider building for it I think. Doesn't have to be in this PR though.

@mholt mholt merged commit 6bc87ea into master Aug 17, 2021
@mholt mholt deleted the go-1.17 branch August 17, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants